fix: rename of NoAccess#93
Merged
Merged
Conversation
NoAccess was renamed to `noAccess` but should be `none`.
Owner
|
Do you want a release for this? |
Contributor
Author
|
No, we still use a fork with a weird implementation for allowing extensions in responses that are not based on a request. The old workaround with a type that serializes to nothing would still include the I still don't have a good solution for this and just needed something that worked. If I find time, I will create a matching issue with some examples so we can think about different solutions to the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NoAccess was incorrectly renamed to
noAccessfor deserialization but should benone.It needs to match:
<access><none/></access>.